Patch Launcher Reset Scroll on Page Change - Revision history

Jakeeeee at 00:42, 22 August 2011

2011-08-22T00:42:16Z

IMGrant: A new version of the patch that is compatible with the Wrap Pages patch - it modifies different parts of the file now.

2009-12-05T13:55:47Z

A new version of the patch that is compatible with the Wrap Pages patch - it modifies different parts of the file now.

Bsiegel: /* Introduction */

2009-10-05T16:17:26Z

Introduction

Jhoff80 at 06:08, 29 September 2009

2009-09-29T06:08:42Z

Egaudet at 04:12, 27 September 2009

2009-09-27T04:12:44Z

AgentTangerine: /* Introduction */

2009-09-25T04:54:51Z

Introduction

Bsiegel: /* Introduction */

2009-09-21T15:32:01Z

Introduction

Hmagoo: /* Introduction */

2009-09-02T23:54:34Z

Introduction

Jhoff80 at 03:55, 31 August 2009

2009-08-31T03:55:17Z

Bsiegel: Initial commit

2009-08-21T21:52:05Z

Initial commit

New page

{{template:patch}}
==Introduction==

If you have many apps on a page, you may have to scroll to see some of those. The launcher maintains the scroll state (the amount you have scrolled) on each page, which means when you return to a page, you are still at the location that you last scrolled to. This can be annoying. For example, it can make it difficult to train your muscle memory because, when repeating the same steps, the app you want is not always at the same location on the screen. This patch resets the scroll of each page back to the top when it goes out of view.

==Editing Process==

* SSH in.
* Remount the filesystem as read/write:
<blockquote><source lang="bash">
sudo rootfs_open -w
</source></blockquote>
* Load launcher-assistant.js in vi:
<blockquote><source lang="bash">
sudo vi /usr/lib/luna/system/luna-applauncher/app/controllers/launcher-assistant.js
</source></blockquote>
* Locate the onPageChange method around line 157:
<blockquote><source lang="javascript">
onPageChange: function(event) {
this.activePageIndex = event.value;
this.updatePageIndicators();
},
</source></blockquote>
* Add the four lines below so that onPageChange now looks like the following:
<blockquote><source lang="javascript">
onPageChange: function(event) {
var scroller = this.getPageScroller();
if (scroller && scroller.mojo) {
scroller.mojo.revealTop(0);
}
this.activePageIndex = event.value;
this.updatePageIndicators();
},
</source></blockquote>
* Save the file and quit vi.
* Remount the filesystem as read only - this should reboot your Pre:
<blockquote><source lang="bash">
sudo rootfs_open -w
</source></blockquote>

==Patch Process==

The patch should soon be located in the webos-internals gitorious repository. Until then, you can copy and paste the source below. Visit [[Applying Patches]] for info on how to use it. To apply the patch, follow the instructions above, and after remounting the filesystem as read/write, do the following:

* Apply the patch (In this example, I have the patch file located in my home directory under '''patches'''):
<blockquote><source lang="bash">
cd /
sudo patch -p0 --backup-if-mismatch < ~/patches/reset-scroll.patch
</source></blockquote>
<blockquote>
This is what you should see if it ran properly:
<source lang="text">
patching file /usr/lib/luna/system/luna-applauncher/app/controllers/launcher-assistant.js
</source></blockquote>
* Remount the filesystem as read only as described above.

===Patch Source (reset-scroll.patch)===

<source lang="diff">
--- /usr/lib/luna/system/luna-applauncher/app/controllers/launcher-assistant.js.bak 2009-05-22 17:12:34.000000000 -0400
+++ /usr/lib/luna/system/luna-applauncher/app/controllers/launcher-assistant.js 2009-08-21 17:19:48.426297000 -0400
@@ -155,6 +155,10 @@

/* keep track of which page we are on */
onPageChange: function(event) {
+ var scroller = this.getPageScroller();
+ if (scroller && scroller.mojo) {
+ scroller.mojo.revealTop(0);
+ }
this.activePageIndex = event.value;
this.updatePageIndicators();
},
</source>

← Older revision		Revision as of 00:42, 22 August 2011
Line 1:		Line 1:
	{{template:patch}}		{{template:patch}}
		+
		+	This is only for webOS 1.4.5 or lower. webOS 2.x and higher have a different launcher implementation that will not work with this patch.
	==Introduction==		==Introduction==

← Older revision		Revision as of 16:17, 5 October 2009
Line 3:		Line 3:

	If you have many apps on a page, you may have to scroll to see some of those. The launcher maintains the scroll state (the amount you have scrolled) on each page, which means when you return to a page, you are still at the location that you last scrolled to. This can be annoying. For example, it can make it difficult to train your muscle memory because, when repeating the same steps, the app you want is not always at the same location on the screen. This patch resets the scroll of each page back to the top when it goes out of view.		If you have many apps on a page, you may have to scroll to see some of those. The launcher maintains the scroll state (the amount you have scrolled) on each page, which means when you return to a page, you are still at the location that you last scrolled to. This can be annoying. For example, it can make it difficult to train your muscle memory because, when repeating the same steps, the app you want is not always at the same location on the screen. This patch resets the scroll of each page back to the top when it goes out of view.
−
−	~~'''Anyone have any luck with this? It's not doing a thing for me.'''~~
−
−	~~'''This is not working for me.''' [[User:Hmagoo\|Hmagoo]] 23:54, 2 September 2009 (UTC)~~
−
−	~~'''It works fine for me. Scroll down on a launcher page so the first row of icons is hidden. Switch to another page, and switch back. The page will be reset back to the top.'''~~
−
−	~~'''This is not working for me either. I have tried this code in a few different ways, and it doesn't work as described. 24 September 2009'''~~
−
−	'''This patch wasn't working because getPageScroller() expects an index as an argument. I have fixed it and will upload it to gitorious as well.''' --[[User:Egaudet\|Egaudet]] 04:12, 27 September 2009 (UTC)

	==Editing Process==		==Editing Process==

← Older revision		Revision as of 04:54, 25 September 2009
Line 9:		Line 9:

	'''It works fine for me. Scroll down on a launcher page so the first row of icons is hidden. Switch to another page, and switch back. The page will be reset back to the top.'''		'''It works fine for me. Scroll down on a launcher page so the first row of icons is hidden. Switch to another page, and switch back. The page will be reset back to the top.'''
		+
		+	'''This is not working for me either. I have tried this code in a few different ways, and it doesn't work as described. 24 September 2009'''

	==Editing Process==		==Editing Process==

← Older revision		Revision as of 15:32, 21 September 2009
Line 7:		Line 7:

	'''This is not working for me.''' [[User:Hmagoo\|Hmagoo]] 23:54, 2 September 2009 (UTC)		'''This is not working for me.''' [[User:Hmagoo\|Hmagoo]] 23:54, 2 September 2009 (UTC)
		+
		+	'''It works fine for me. Scroll down on a launcher page so the first row of icons is hidden. Switch to another page, and switch back. The page will be reset back to the top.'''

	==Editing Process==		==Editing Process==

← Older revision		Revision as of 23:54, 2 September 2009
Line 5:		Line 5:

	'''Anyone have any luck with this? It's not doing a thing for me.'''		'''Anyone have any luck with this? It's not doing a thing for me.'''
		+
		+	'''This is not working for me.''' [[User:Hmagoo\|Hmagoo]] 23:54, 2 September 2009 (UTC)

	==Editing Process==		==Editing Process==

@@ Line 3: / Line 3: @@
 If you have many apps on a page, you may have to scroll to see some of those. The launcher maintains the scroll state (the amount you have scrolled) on each page, which means when you return to a page, you are still at the location that you last scrolled to. This can be annoying. For example, it can make it difficult to train your muscle memory because, when repeating the same steps, the app you want is not always at the same location on the screen. This patch resets the scroll of each page back to the top when it goes out of view.
 ==Editing Process==
@@ Line 15: / Line 17: @@
 sudo vi /usr/lib/luna/system/luna-applauncher/app/controllers/launcher-assistant.js
 </source></blockquote>
-* Locate the onPageChange method around line 157 (line 158 in webOS 1.2):
+* Locate the end of the setup method, around line 98:
 <blockquote><source lang="javascript">
-onPageChange: function(event) {
+		// setup the initial dimensions for launcher/global-search
-	this.activePageIndex = event.value;
+		this.adjustLayout();
-	this.updatePageIndicators();
-},
+		// add a separate listener for resetting the scroll position on page changes, and also on deactivate
 </source></blockquote>
-* Add the four lines below so that onPageChange now looks like the following:
+* Add the following method somewhere else in the file, I suggest just below the ready method and before the deleteAllPages method, around line 105 (don't forget the comma after the closing brace, unless you add it right at the end of the class, as the last method):
 <blockquote><source lang="javascript">
-onPageChange: function(event) {
+	resetScrollPosition: function(event) {
-	var scroller = this.getPageScroller(this.activePageIndex);
+		var pageIndex = (event.type === 'mojo-event-deactivate') ? this.activePageIndex : event.value;
-	if (scroller && scroller.mojo) {
+		var scroller = this.getPageScroller(pageIndex);
-		scroller.mojo.revealTop(0);
+		if (scroller && scroller.mojo) { scroller.mojo.revealTop(); }
 	},
 </source></blockquote>
 * Save the file and quit vi.
@@ Line 42: / Line 58: @@
 ==Patch Process==
-The patch should soon be located in the webos-internals gitorious repository. Until then, you can copy and paste the source below. Visit [[Applying Patches]] for info on how to use it. To apply the patch, follow the instructions above, and after remounting the filesystem as read/write, do the following:
+An older version of the patch is in the git/Preware repository, hopefully this version will be submitted soon. Until then, you can copy and paste the source below. Visit [[Applying Patches]] for info on how to use it. You can also apply it using webOS Quick Install. To apply the patch, follow the instructions above, and after remounting the filesystem as read/write, do the following:
 * Apply the patch (In this example, I have the patch file located in my home directory under '''patches'''):
@@ Line 60: / Line 76: @@
 <source lang="diff">
---- /usr/lib/luna/system/luna-applauncher/app/controllers/launcher-assistant.js.bak	2009-05-22 17:12:34.000000000 -0400
+--- /usr/lib/luna/system/luna-applauncher/app/controllers/launcher-assistant.js.orig	Sat Dec  5 11:48:12 2009
-+++ /usr/lib/luna/system/luna-applauncher/app/controllers/launcher-assistant.js	2009-08-21 17:19:48.426297000 -0400
++++ /usr/lib/luna/system/luna-applauncher/app/controllers/launcher-assistant.js	Thu Dec  3 19:42:03 2009
-@@ -155,6 +155,10 @@
+@@ -98,5 +98,9 @@
-  	/* keep track of which page we are on */
+  	ready: function() {
- 	onPageChange: function(event) {
+@@ -188,6 +188,12 @@
-+        var scroller = this.getPageScroller(this.activePageIndex);
+ 	onResize: function(event) {
-+        if (scroller && scroller.mojo) {
+  		this.adjustLayout();
   	},
 </source>

← Older revision		Revision as of 03:55, 31 August 2009
Line 3:		Line 3:

	If you have many apps on a page, you may have to scroll to see some of those. The launcher maintains the scroll state (the amount you have scrolled) on each page, which means when you return to a page, you are still at the location that you last scrolled to. This can be annoying. For example, it can make it difficult to train your muscle memory because, when repeating the same steps, the app you want is not always at the same location on the screen. This patch resets the scroll of each page back to the top when it goes out of view.		If you have many apps on a page, you may have to scroll to see some of those. The launcher maintains the scroll state (the amount you have scrolled) on each page, which means when you return to a page, you are still at the location that you last scrolled to. This can be annoying. For example, it can make it difficult to train your muscle memory because, when repeating the same steps, the app you want is not always at the same location on the screen. This patch resets the scroll of each page back to the top when it goes out of view.
		+
		+	'''Anyone have any luck with this? It's not doing a thing for me.'''

	==Editing Process==		==Editing Process==